Support for more backends #797
Open
+460
−349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
requested review from
z-tech,
mmagician and
weikengchen
and removed request for
a team
tcoratger
reviewed
Feb 27, 2024
| } | ||
|
|
||
| pub(super) const fn mul_without_cond_subtract(mut self, other: &Self) -> (bool, Self) { | ||
| let (mut lo, mut hi) = ([0u64; N], [0u64; N]); |
There was a problem hiding this comment.
Why not using the MulBuffer helper here for an easier manipulation?
There was a problem hiding this comment.
Good question, it's been a while since I looked at this code =)
|
This is the basically tackling #769 (comment) right? |
mmagician
reviewed
Mar 6, 2024
Comment on lines
+295
to
+298
| // We compute this as follows. | ||
| // First, MODULUS mod 2^64 is just the lower 64 bits of MODULUS. | ||
| // Hence MODULUS mod 2^64 = MODULUS.0[0] mod 2^64. | ||
| // |
There was a problem hiding this comment.
As a follow-up to this PR, the next step would be to rename this existing BigInt to BigInt64, and then also add a BigInt32, correct?
Comment on lines
+68
to
71
| /// Does the modulus have a spare unused bit (i.e., the MSB is 0) | ||
| /// | ||
| /// This condition applies if | ||
| /// (a) `Self::MODULUS[N-1] >> 63 == 0` |
There was a problem hiding this comment.
The comment Self::MODULUS[N-1] >> 63 == 0 would (later) need to be changed to reflect that the underlying representation might be other than an array of u64s.
|
|
||
| /// (MODULUS + 1) / 4 when MODULUS % 4 == 3. Used for square root precomputations. | ||
| /// | ||
| /// Can be computed if the `BigInt` type has a `plus_one_div_four` method. |
There was a problem hiding this comment.
And otherwise?
Do you mean if plus_one_div_four returns Some(...)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer