Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using RPITIT for to_base_prime_field_elements #751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch to using RPITIT for to_base_prime_field_elements #751

wants to merge 1 commit into from
+10 −19

Conversation

Pratyush
Copy link
Member

Description

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@Pratyush Pratyush requested review from a team as code owners January 12, 2024 22:07
@Pratyush Pratyush requested review from z-tech, mmagician and weikengchen and removed request for a team January 12, 2024 22:07
@mmagician
Copy link
Member

We're still at minimum supported rust-version = "1.70", so we'd need to bump to 1.75 first, which would be pretty limiting to some projects.

@Pratyush
Copy link
Member Author

We can hold off on this for a couple of release, just wanted to get this on the radar.

@mmagician mmagician added the do-not-merge-now Do not merge due to conflicts with more important PRs label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge-now Do not merge due to conflicts with more important PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pratyush @mmagician