Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce benchmark startup time and StarkNet field #654

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Reduce benchmark startup time and StarkNet field #654

wants to merge 11 commits into from

Conversation

Pratyush
Copy link
Member

Description

Reduces startup time for our benchmarks via faster sampling of group elements. Additionally, adds the StarkNet field for future benchmark.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@Pratyush Pratyush requested review from a team as code owners May 31, 2023 21:56
@Pratyush Pratyush requested review from mmagician and weikengchen and removed request for a team May 31, 2023 21:56
@Pratyush
Copy link
Member Author

This needs some fixes still; I'll convert to draft for the time being

@mmagician
Copy link
Member

Is this still WIP?

@Pratyush
Copy link
Member Author

Yup still WIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmagician mmagician mmagician approved these changes

@weikengchen weikengchen weikengchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pratyush @mmagician @weikengchen