Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify SquareRootField and Field #387

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Unify SquareRootField and Field #387

wants to merge 9 commits into from

Conversation

solomonjoseph
Copy link
Contributor

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

Pratyush
Pratyush reviewed Feb 8, 2022
View reviewed changes
ec/src/models/bls12/mod.rs Outdated Show resolved Hide resolved
Pratyush
Pratyush reviewed Feb 8, 2022
View reviewed changes
ec/src/models/bn/mod.rs Outdated Show resolved Hide resolved
Pratyush
Pratyush reviewed Feb 8, 2022
View reviewed changes
ec/src/models/bw6/mod.rs Outdated Show resolved Hide resolved
Pratyush
Pratyush reviewed Feb 8, 2022
View reviewed changes
ec/src/models/mnt4/mod.rs Outdated Show resolved Hide resolved
Pratyush
Pratyush reviewed Feb 8, 2022
View reviewed changes
ff/src/lib.rs Outdated Show resolved Hide resolved
Pratyush
Pratyush reviewed Feb 8, 2022
View reviewed changes
test-templates/src/fields.rs
@@ -397,7 +397,7 @@ pub fn montgomery_primefield_test<T: MontConfig<N>, const N: usize>() {
}
}

pub fn sqrt_field_test<F: SquareRootField>(elem: F) {
pub fn sqrt_field_test<F: Field>(elem: F) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should integrate these into the existing field_test

@mmagician mmagician mentioned this pull request May 25, 2022
Merged
10 tasks
@Pratyush Pratyush reopened this Oct 26, 2022
@Pratyush
Copy link
Member

Pratyush commented Nov 2, 2022

Reopening this so that we can reuse the other sqrt algorithms that have been implemented in this branch, but haven't been merged to master yet. CC @alexander-zw @mmagician in case y'all were interested.

@mmagician mmagician mentioned this pull request Dec 13, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@solomonjoseph @Pratyush