Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: import aioeapi module #676

Merged
merged 16 commits into from
May 17, 2024
Merged

Conversation

mtache
Copy link
Collaborator

@mtache mtache commented May 14, 2024

Import aioeapi module from Jeremy Schulman repository at https://github.com/jeremyschulman/aio-eapi

Update the codebase to comply with ANTA's linting rules.

Also populate the eAPI id field with "ANTA-" or "ANTA--".
When running NRFU, the collection ID is the test name.

This allows for easier eAPI requests debug on the device using EOS configuration: trace CapiApp setting UwsgiRequestContext/4,CapiUwsgiServer/4

bash tail -f /var/log/agents/CapiApp-*

2024-05-15 15:32:54.056166  1429 UwsgiRequestContext  4 request content b'{"jsonrpc": "2.0", "method": "runCmds", "params": {"version": "latest", "cmds": [{"cmd": "show ip route vrf default 10.255.0.3", "revision": 4}], "format": "json", "autoComplete": false, "expandAliases": false}, "id": "ANTA-VerifyRoutingTableEntry-132366530677328"}'

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@mtache mtache marked this pull request as ready for review May 15, 2024 14:27
@mtache mtache requested review from gmuloc, titom73 and carl-baillargeon and removed request for titom73 May 15, 2024 15:45
@mtache mtache linked an issue May 15, 2024 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let s add a kudo to Jerermy and a link in our README

docs/troubleshooting.md Outdated Show resolved Hide resolved
docs/troubleshooting.md Outdated Show resolved Hide resolved
anta/device.py Outdated Show resolved Hide resolved
anta/device.py Outdated Show resolved Hide resolved
anta/device.py Outdated Show resolved Hide resolved
anta/device.py Outdated Show resolved Hide resolved
asynceapi/__init__.py Show resolved Hide resolved
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 :shipit:

@gmuloc gmuloc merged commit 700269a into arista-netdevops-community:main May 17, 2024
17 checks passed
@mtache mtache deleted the aioeapi branch May 17, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support Python 3.12
4 participants