Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again 馃帀
I've fixed that if
swapSuggestions
is called twice in a row, then the suggestions are displayed incorrectly.The problem
OnGlobalLayoutListener
is called twice for single suggestion swap if we callswapSuggestion
in the same frame. The problem is that the second time we callswapSuggestion
,OnGlobalLayoutListener
has still not being called, so it ends up calling it twice (or many times).The solution
Instead of removing the listener when it's processed, we remove it every time we try to swap suggestions.
Test
To test this problem, I've called the
swapSuggestions
twice in a row:Before the fix
After the fix