Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated argument from IonicAudioModule.forRoot in demo #99

Open
wants to merge 2 commits into
base: 2.0
Choose a base branch
from

Conversation

lujakob
Copy link

@lujakob lujakob commented Feb 27, 2017

After running the demo app the following Typescript error is thrown:
Argument of type '{ provide: typeof AudioProvider; useFactory: any; }' is not assignable to parameter of type 'AudioProvider'. In the module definition the argument is of type AudioProvider, so I guess there have been changes and this is a leftover. I removed the arguments for the demo app.module definition to use the argument defaults instead (as it is seen in the installed npm package)

@sfaizanh
Copy link

@lujakob can you explain me why this is also included

/**
 * Sample custom factory function to use with ionic-audio
 */
export function myCustomAudioProviderFactory() {
  return new WebAudioProvider();
}

do we need it? and second thing AudioProvider in import?

@lujakob
Copy link
Author

lujakob commented Feb 27, 2017

export function myCustomAudioProviderFactory is not needed but added by the author as an example for adding a custom AudioProvider. And as it's a demo, I didn't want to remove it (I wouldn't want to take the authority, I just fixed an error).
AudioProvider in the import is unused as well and can be removed, correct.

@sfaizanh
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants