refactor(test): use t.Setenv
#13036
Merged
refactor(test): use t.Setenv
#13036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [`t.Setenv`](https://pkg.go.dev/testing#B.Setenv) handles setting the env var back to what it was after - automates the `defer` + `Unsetenv` at the end - and is more correct -- it always sets it back to what it was, not just unsets it - also catches a few places where the `defer` was missed which could've resulted in some incorrect tests Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
juliev0
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12862 (comment), #12756 (comment)
Motivation
t.Setenvhandles setting the env var back to what it was afterdefer+Unsetenvat the enddeferwas missed which could've resulted in some incorrect testsModifications
os.Setenv+os.Unsetenv->t.SetenvVerification
Existing tests should pass