Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update installation doc to improve compatibility #581

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

this-is-tobi
Copy link

@this-is-tobi this-is-tobi commented Nov 19, 2023

Description

This PR update the installation page in the documentation to include some vars to the argocd-vault-plugin download. This improve compatibility for Darwin and ARM64 as the command compute the url to download the appropriate binary.

It also updates the AVP_PLUGIN version to 1.17.0 in the installation documentation.

Fixes: <! -- link to issue -->

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.21 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

@this-is-tobi this-is-tobi force-pushed the docs/update-installation-doc branch 2 times, most recently from 3b20caa to 8575f3c Compare November 25, 2023 12:29
@jacksgt
Copy link

jacksgt commented Jan 11, 2024

Hi, I think this is a good contribution. Could somebody merge it please?

@this-is-tobi this-is-tobi force-pushed the docs/update-installation-doc branch 2 times, most recently from 7926e86 to e5fb732 Compare January 18, 2024 04:30
@this-is-tobi
Copy link
Author

@werne2j @jkayani Is there something wrong for you ? Maybe you prefer just to declare arch as argument like AVP_PLUGIN ?

Signed-off-by: this-is-tobi <thibault_colin@hotmail.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants