Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 📝 Update installation doc #485

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krausemi
Copy link

Description

Within this PR the custom docker file for the sidecar has been updated as the one which is currently available is not working.
Furthermore the spawning of zombie bash processes has been avoided by using tini as entrypoint.

Fixes: #460

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

@werne2j
Copy link
Member

werne2j commented Mar 31, 2023

@krausemi can you sign-off on the commit for the DCO to pass? Thanks.

Signed-off-by: Michael Krause <krausemi@posteo.de>
@krausemi
Copy link
Author

krausemi commented Apr 4, 2023

@werne2j: done. Sorry for the little delay.

@codecov-commenter
Copy link

Codecov Report

Merging #485 (90a4580) into main (b587367) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   75.31%   75.31%           
=======================================
  Files          25       25           
  Lines        1689     1689           
=======================================
  Hits         1272     1272           
  Misses        323      323           
  Partials       94       94           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants