Use user 999 for initContainer as in sidecar #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvesZelros
suggested changes
Sep 14, 2023
fty4
commented
Sep 29, 2023
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
As @YvesZelros suggested the temporary directory is not required. Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
…ycontext-initcontainer Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
fty4
force-pushed
the
chore/install-securitycontext-initcontainer
branch
from
a859aa8
to
5beef79
Compare
|
forced push to pass DCO |
|
Looks good to me, could someone please approve and merge the PR? @werne2j @YvesZelros |
yyvess
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently only the
avp(sidecar) container uses the user999.But the same image is used for the initContainer
download-tools.It might be good to use the same user here as well.
As the user has no permission in the current workdir a temp dir is used to download the binary.
Checklist
Please make sure that your PR fulfills the following requirements:
Tests for the changes have been updatedAre you adding dependencies? If so, please rungo mod tidy -compat=1.17to ensure only the minimum is pulled in.Optional. My organization is added to USERS.md.Type of Change