Restructure manifests into Components for composability #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
jkayani
reviewed
Jul 15, 2022
jskrzypek
force-pushed
the
jskrzypek/plugin-components
branch
from
532e122
to
5c41b33
Compare
|
@jskrzypek Can you rebase your PR with main? Thanks! |
Restructuring the manifests to allow consumers of AVP to bring their own argocd base by using the kustomize components manifests under `manifests/components`. This allows consumers to integrate more easily with other CMPs or alternate versions of argo that the AVP maintainers haven't patched the manifests to include. NB this requires use of kustomize > v3.7.0 when Components were introduced. For more information about components see the docs: https://kubectl.docs.kubernetes.io/guides/config_management/components/
PR argoproj-labs#352 introduced the sidecar pattern, but also renamed the prior default manifest, which was available through a reference to https://github.com/argoproj-labs/argocd-vault-plugin//manifests To get the same app, consumers would need to change any exsting references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap This commit introduces a simple proxy manifest that makes that change backwards compatible, meaning that now older references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests will still resolve to the same app state as https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap rather than just breaking.
Describe how to use the plugin-only component manifests for use with alternate versions of ArgoCD (e.g. HA, newer releases, etc.)
jskrzypek
force-pushed
the
jskrzypek/plugin-components
branch
from
5c41b33
to
fdea29b
Compare
|
@werne2j done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am replacing PR #370 with this one because on further testing I realized that while Kustomize successfully built the resources, the patches were not actually applied. This strategy of using Kustomize Components actually works and produces the intended effect.
The changes included are described in the commit messages:
Fixes: #369
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.17to ensure only the minimum is pulled in.Type of Change
Other information
Closing #370 in favor of this PR