Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
golangci-lint
This PR adds golangci-lint to this repo, enforces a few good and standard Go practices with the default linters:
And two extra linters that a nice to have to follow stylistic conventions.
Makefile makeover
Added
.PHONY
tags to the makefile, since the target don't actually point to any files. I also added independent targets for vet, lint and test for easy individual execution and linked then all up to quality.Rest of the changes
The rest of the changes are only to make the linter happy. Conventions weren't followed in some places (errors weren't being checked, etc.), so this just fixes and brings everything up to standard.
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.17
to ensure only the minimum is pulled in.Type of Change