doc: Update installation.md #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ileriayo
force-pushed
the
patch-1
branch
2 times, most recently
from
c89e7b4
to
4db0926
Compare
chengfang
reviewed
May 1, 2024
| @@ -19,7 +19,7 @@ Argo CD is running. Don't worry, without any configuration, it will not start me | |||
| We also provide a Kustomize base in addition to the plain Kubernetes YAML | |||
| manifests. You can use it as remote base and create overlays with your | |||
| configuration on top of it. The remote base's URL is | |||
| `https://github.com/argoproj-labs/argocd-image-updater/manifests/base` | |||
| `https://github.com/argoproj-labs/argocd-image-updater/tree/master/manifests/base` | |||
|
|
|||
There was a problem hiding this comment.
Maybe we can use the stable version, to be consistent with the install.yaml later in this doc:
https://github.com/argoproj-labs/argocd-image-updater/tree/stable/manifests/base
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #703 +/- ##
=======================================
Coverage 66.27% 66.27%
=======================================
Files 22 22
Lines 2150 2150
=======================================
Hits 1425 1425
Misses 591 591
Partials 134 134 ☔ View full report in Codecov by Sentry. |
chengfang
approved these changes
May 3, 2024
|
Pls see comments in #533 |
|
Correct! @chengfang |
|
LGTM |
pasha-codefresh
added
the
documentation
|
@Ileriayo could you please fix DCO? |
Ileriayo
force-pushed
the
patch-1
branch
4 times, most recently
from
d5db845
to
2bb0d95
Compare
Signed-off-by: Ileriayo Adebiyi <ileriayoadebiyi@gmail.com>
Done @pasha-codefresh |
pasha-codefresh
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace invalid GitHub url reference with the right one that points to the codebase on the master branch.