fix: writing helm values back to git #693
Open
+85
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is based of work in PR #637 but it use the latest master |
Signed-off-by: Romain Caire <super.cairos@gmail.com>
supercairos
changed the title
|
Feel free to review @jannfis |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #693 +/- ##
==========================================
+ Coverage 66.27% 66.59% +0.31%
==========================================
Files 22 22
Lines 2150 2176 +26
==========================================
+ Hits 1425 1449 +24
- Misses 591 592 +1
- Partials 134 135 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Romain Caire <super.cairos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a write-back feature on a helm backed repository, keys were not printed correctly.
This PR fixe this and also allow usage of vault-helm plugin.