Add compatibility for multiple sources #635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 25, 2023 11:25
…etSources[0] instead Signed-off-by: Casey Morton <cmorton@exiger.com>
Signed-off-by: Casey Morton <cmorton@exiger.com>
Signed-off-by: Casey Morton <cmorton@exiger.com>
added 3 commits
October 25, 2023 11:40
Signed-off-by: Casey Morton <cmorton@exiger.com>
Signed-off-by: Casey Morton <cmorton@exiger.com>
Signed-off-by: Casey Morton <cmorton@exiger.com>
|
It all looks pretty good, however I'm not sure if there was anything done
to be able to target multiple images in this PR, the way that mine has.
Casey
…On Mon, Dec 4, 2023 at 3:51 PM jannfis ***@***.***> wrote:
Hi! Thanks so much for your PR and sorry for responding so late!
I have just merged #636
<#636> - Is
there something in your PR that has not been covered by #636
<#636>?
—
Reply to this email directly, view it on GitHub
<#635 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMDUFTRLGFZ76YFVB6IPYLYHYZURAVCNFSM6AAAAAA6PSKRYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZGQ2TKNRZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for multiple sources as well as the ability to target individual aliases for specific sources. I realize the documentation needs to be updated for the new annotations I have added and some of the code may need some work as this my first real crack at GoLang. Be gentle :)