Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SDK support for multi label options_order #4757

Merged
merged 15 commits into from May 3, 2024

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Apr 29, 2024

Description

This PR add support to new options_order attribute for multi-label questions so it is possible to specify an order to use when rendering labels on the UI.

In the backend options_order is the used attribute but in the SDK I have used labels_order so it matches with the rest of attributes like visible_labels.

Closes #4756

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Modify already existent tests to support new feature.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon April 29, 2024 14:23
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. area: python sdk Indicates that an issue or pull request is related to the Python SDK area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests labels Apr 29, 2024
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4757-ki24f765kq-no.a.run.app

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 3, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 3, 2024
@jfcalvo jfcalvo merged commit 92c7815 into develop May 3, 2024
14 checks passed
@jfcalvo jfcalvo deleted the feat/add-sdk-support-for-multi-label-options-order branch May 3, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK area: ui Indicates that an issue or pull request is related to the User Interface (UI) lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. type: enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] SDK support for new options_order attribute on multi label question settings
2 participants