feat: added helm chart #4065
feat: added helm chart #4065
Conversation
There was a problem hiding this comment.
Hi @Arvind644, thanks for the PR! Could we make the Elasticsearch deployment optional? I would like to toggle the Elasticsearch deployment based on a value of the Helm template.
k8s/helm chart/argilla/templates/argilla-server-deployment.yaml
Outdated
Show resolved
Hide resolved
@gabrielmbmb Does I have to make optional deployment for all of these - |
davidberenstein1957
added
the
team: ml
|
@gabrielmbmb I have done all the changes, please review my PR. |
| image: argilla/argilla-server:latest | ||
| env: | ||
| - name: {{ .Values.argilladeployment.name }} | ||
| value: "http://elasticsearch:9200" |
There was a problem hiding this comment.
This should also be Values.argilladeployment.elasticurl
| - name: argilla-server | ||
| image: argilla/argilla-server:latest | ||
| env: | ||
| - name: {{ .Values.argilladeployment.name }} |
There was a problem hiding this comment.
This env name is required by Argilla and wouln't change between deployments. Leaving it as ARGILLA_ELASTICSEARCH should suffice.
| {{- end }} | ||
| containers: | ||
| - name: argilla-server | ||
| image: argilla/argilla-server:latest |
There was a problem hiding this comment.
Suggestion: swap latest for something like Values.imageTag in case users want to pin the image version (e.g., to 1.16 or something)
| value: "http://elasticsearch:9200" | ||
| ports: | ||
| - containerPort: 6900 | ||
| resources: |
There was a problem hiding this comment.
Suggestions: resources often vary among deployments, and so making these into Values values is probably a good practice
| @@ -0,0 +1,18 @@ | |||
| apiVersion: autoscaling/v2 | |||
There was a problem hiding this comment.
Suggestion: wrap HPAs in something like {{- if .Values.autoscaling.enabled }}
| @@ -0,0 +1,38 @@ | |||
| apiVersion: apps/v1 | |||
There was a problem hiding this comment.
Suggestion: I would consider adding a PVC for the Argilla deployment so that workspaces/users persist beyond restarts/redeployments and mount it to ARGILLA_HOME_PATH.
|
Thanks a lot for your help @jakemiller649 and @Arvind644 💪🏽 |
|
@Arvind644, are you able to continue work on this or can @gabrielmbmb, further fine-tune the contribution? |
|
As per some suggestions of Robert Pack:
|
No description provided.