Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Responses and Suggestions are not validated when adding records #3938

Conversation

frascuchon
Copy link
Member

Description

The problem found with this can make users push datasets in Huggingface with wrong responses.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@davidberenstein1957
Copy link
Member

This is great too! Thanks Paco ❤️

@frascuchon frascuchon changed the title bug: Responses are not validated when adding records bug: Responses and Suggestions are not validated when adding records Oct 12, 2023
@frascuchon frascuchon added this to the v1.18.0 milestone Oct 19, 2023
@davidberenstein1957 davidberenstein1957 added the team: ml Indicates that the issue or pull request is owned by the Machine Learning (ML) team label Oct 31, 2023
@nataliaElv nataliaElv modified the milestones: v1.18.0, v1.19.0 Oct 31, 2023
@frascuchon frascuchon modified the milestones: v1.19.0, v1.20.0 Nov 8, 2023
@nataliaElv nataliaElv modified the milestones: v1.20.0, v1.21.0 Nov 28, 2023
@frascuchon frascuchon removed this from the v1.21.0 milestone Dec 19, 2023
@alvarobartt alvarobartt removed their assignment Dec 19, 2023
@frascuchon
Copy link
Member Author

This will tackle in the future version of the SDK

@frascuchon frascuchon closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: ml Indicates that the issue or pull request is owned by the Machine Learning (ML) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants