feat: CI runtime improvements #3893
Conversation
gabrielmbmb
force-pushed
the
feature/ci-runtime-improvements
branch
from
10d7bc3
to
8805151
Compare
gabrielmbmb
force-pushed
the
feature/ci-runtime-improvements
branch
from
8805151
to
4e818ba
Compare
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3893-ki24f765kq-no.a.run.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 269 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
gabrielmbmb
force-pushed
the
feature/ci-runtime-improvements
branch
from
bde4c74
to
d87055f
Compare
gabrielmbmb
force-pushed
the
feature/ci-runtime-improvements
branch
4 times, most recently
from
5e672a4
to
163e0fd
Compare
gabrielmbmb
force-pushed
the
feature/ci-runtime-improvements
branch
9 times, most recently
from
8713b45
to
80c7663
Compare
gabrielmbmb
force-pushed
the
feature/ci-runtime-improvements
branch
from
80c7663
to
1fdecd0
Compare
There was a problem hiding this comment.
I think we can also add more granularity when only building changing tests for example. Like here: https://github.com/argilla-io/argilla/pulls
| if: steps.cache.outputs.cache-hit != 'true' | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m pip install -e .[server,postgresql,tests,integrations,listeners] |
There was a problem hiding this comment.
Isn't there a command to install with --all-extras? this might lead to unwanted side effects w.r.t. changes we make in the extras.
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-python@v4 |
There was a problem hiding this comment.
maybe it is a good moment to also start testing different python versions?
| platforms: linux/arm64 | ||
| secrets: inherit | ||
|
|
||
| build_quickstart_docker_image_linux_arm64: |
There was a problem hiding this comment.
can't we combine this using a template combined with build_quickstart_docker_image_linux_amd64?
| - name: Set huggingface hub credentials | ||
| if: github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/releases') | ||
| env: | ||
| HF_HUB_ACCESS_TOKEN: ${{ secrets.HF_HUB_ACCESS_TOKEN }} | ||
| run: echo "Enable HF access token" | ||
|
|
||
| - name: Run tests 📈 | ||
| env: | ||
| ARGILLA_ENABLE_TELEMETRY: 0 |
There was a problem hiding this comment.
I noticed we are not passing HF_HUB_ACCESS_TOKEN here but I know we do have some tests for this. Maybe it is a good moment to review this?
Description
WIP
Closes #<issue_number>
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)