Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] SDK support for new options_order attribute on multi label question settings #4756

Closed
Tracked by #4647
jfcalvo opened this issue Apr 29, 2024 · 0 comments · Fixed by #4757
Closed
Tracked by #4647

[TASK] SDK support for new options_order attribute on multi label question settings #4756

jfcalvo opened this issue Apr 29, 2024 · 0 comments · Fixed by #4757
Assignees
Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK team: backend Indicates that the issue or pull request is owned by the backend team type: enhancement Indicates new feature requests

Comments

@jfcalvo
Copy link
Member

jfcalvo commented Apr 29, 2024

No description provided.

@jfcalvo jfcalvo self-assigned this Apr 29, 2024
@dosubot dosubot bot added area: python sdk Indicates that an issue or pull request is related to the Python SDK team: backend Indicates that the issue or pull request is owned by the backend team type: enhancement Indicates new feature requests labels Apr 29, 2024
jfcalvo added a commit that referenced this issue May 3, 2024
# Description

This PR add support to new `options_order` attribute for multi-label
questions so it is possible to specify an order to use when rendering
labels on the UI.

In the backend `options_order` is the used attribute but in the SDK I
have used `labels_order` so it matches with the rest of attributes like
`visible_labels`.

Closes #4756 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)
- [ ] Documentation update

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [x] Modify already existent tests to support new feature.

**Checklist**

- [ ] I added relevant documentation
- [ ] follows the style guidelines of this project
- [ ] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK team: backend Indicates that the issue or pull request is owned by the backend team type: enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant