Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5869, missing white channnel for WS2812 #5878

Merged
merged 2 commits into from May 29, 2019
Merged

Fix #5869, missing white channnel for WS2812 #5878

merged 2 commits into from May 29, 2019

Conversation

s-hadinger
Copy link
Collaborator

Description:

The light_subtype was updated after initializing the Light engine, missing the white channel.

**Related issue (if applicable): #5869

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched (Also remember to update changelog.ino file)
  • Only one feature/fix was added per PR.
  • The code change is tested and works.
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@s-hadinger s-hadinger mentioned this pull request May 29, 2019
Closed
2 tasks
@arendst arendst merged commit 6d7d836 into arendst:development May 29, 2019
@Jason2866 Jason2866 mentioned this pull request May 31, 2019
Closed
@s-hadinger s-hadinger deleted the fix/ws2812_rgbw branch June 12, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascillato ascillato ascillato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@s-hadinger @ascillato @arendst