Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-translated media fields display as empty #483

Open
daun opened this issue Dec 9, 2019 · 2 comments · May be fixed by #2525
Open

Non-translated media fields display as empty #483

daun opened this issue Dec 9, 2019 · 2 comments · May be fixed by #2525
Assignees
Labels
impact: low a minor issue for some people type: bug Something isn't working

Comments

@daun
Copy link
Contributor

daun commented Dec 9, 2019

Description of the issue:

On a site with translated media fields, using a non-translated media field will display the field as empty in the edit form even though it is saved correctly in the database and holds data.

Steps to reproduce:

  1. Enable translated media form fields by setting twill.media_library.translated_form_fields to true
  2. Add a non-translated media form field to a module form by setting its translated parameter to false
  3. Open the edit form for a single entry of that module
  4. Attach an image from the media library to the non-translated media field
  5. Save changes
  6. Reload browser window

Expected behavior:

The media relation is saved in the database and displayed in the edit form on reload.

Actual behavior:

The media relation is saved correctly but the media form field is empty on reload.

Notes:

I think the translated_form_fields shouldn't be global. Some fields require it, some don't, so there should be a way of overriding the global setting for single fields. Twill's data structure is set up well for handling this. It's probably a question of how to detect the data format.

@agnonym
Copy link
Contributor

agnonym commented Feb 10, 2020

Same issue here... Activating translated_form_fields on an existing project breaks the already defined media fields

@ptrckvzn ptrckvzn added the type: bug Something isn't working label Apr 26, 2021
@ifox ifox added the impact: low a minor issue for some people label Feb 6, 2022
@petertsoisstuff
Copy link
Contributor

Same here, Does anyone have a solution to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: low a minor issue for some people type: bug Something isn't working
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

6 participants