Skip to content

Commit

Permalink
chore: use Node.js >=18.17.0
Browse files Browse the repository at this point in the history
remove `msvs_version` npm config on win32
Ref: nodejs/node-gyp#2822

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
  • Loading branch information
Akos Kitta authored and kittaakos committed Sep 26, 2023
1 parent 8a5dee9 commit bb4b145
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 92 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/build.yml
Expand Up @@ -85,10 +85,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v4

- name: Install Node.js 16.14
- name: Install Node.js 18.17
uses: actions/setup-node@v3
with:
node-version: '16.14'
node-version: '18.17'
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down Expand Up @@ -131,10 +131,6 @@ jobs:
export CSC_FOR_PULL_REQUEST=true
fi
if [ "${{ runner.OS }}" = "Windows" ]; then
npm config set msvs_version 2017 --global
fi
npx node-gyp install
yarn install --immutable
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-i18n-task.yml
Expand Up @@ -58,10 +58,10 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4

- name: Install Node.js 16.14
- name: Install Node.js 18.17
uses: actions/setup-node@v3
with:
node-version: '16.14'
node-version: '18.17'
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/compose-full-changelog.yml
Expand Up @@ -8,7 +8,7 @@ on:
env:
CHANGELOG_ARTIFACTS: changelog
# See: https://github.com/actions/setup-node/#readme
NODE_VERSION: 16.x
NODE_VERSION: '18.17'

jobs:
create-changelog:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/i18n-nightly-push.yml
Expand Up @@ -16,10 +16,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v4

- name: Install Node.js 16.14
- name: Install Node.js 18.17
uses: actions/setup-node@v3
with:
node-version: '16.14'
node-version: '18.17'
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/i18n-weekly-pull.yml
Expand Up @@ -16,10 +16,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v4

- name: Install Node.js 16.14
- name: Install Node.js 18.17
uses: actions/setup-node@v3
with:
node-version: '16.14'
node-version: '18.17'
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down
71 changes: 0 additions & 71 deletions docs/internal/Arm.md

This file was deleted.

18 changes: 11 additions & 7 deletions docs/internal/Ubuntu.md
@@ -1,6 +1,8 @@
### Building and start the app from the sources on Ubuntu Linux

Tested and verified on Ubuntu 18.04.4. The source will be checked out to `~/dev/git/arduino-ide`.
Tested and verified on Ubuntu 22.04. The source will be checked out to `~/dev/git/arduino-ide`.

> ❗ This is an all-in-one script to create production-ready, minified code; you will need ~16GB of RAM to run it. This script will install libraries you might already have on your system and change the default Node.js version you do not want. If you look for documentation on development, please reference [this](../development.md#prerequisites) section instead.
```
#!/bin/bash -i
Expand All @@ -11,23 +13,25 @@ sudo apt update \
gcc \
curl \
make \
python \
python3 \
pkg-config \
libx11-dev \
libxkbfile-dev \
build-essential \
libsecret-1-dev \
&& wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | bash \
&& source ~/.bashrc \
&& nvm install 16 \
&& nvm use 16 \
&& nvm alias default 16 \
&& nvm install 18.17 \
&& nvm use 18.17 \
&& nvm alias default 18.17 \
&& curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add - \
&& echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list \
&& sudo apt update && sudo apt install --no-install-recommends yarn \
&& mkdir -p ~/dev/git/ \
&& rm -rf ~/dev/git/arduino-ide \
&& git clone --depth 1 https://github.com/arduino/arduino-ide.git ~/dev/git/arduino-ide \
&& yarn --cwd ~/dev/git/arduino-ide \
&& yarn --cwd ~/dev/git/arduino-ide rebuild:electron \
&& yarn --cwd ~/dev/git/arduino-ide/electron-app start
&& yarn --cwd ~/dev/git/arduino-ide/electron-app rebuild \
&& yarn --cwd ~/dev/git/arduino-ide build \
&& yarn --cwd ~/dev/git/arduino-ide start
```
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -7,7 +7,7 @@
"license": "AGPL-3.0-or-later",
"private": true,
"engines": {
"node": ">=16.14.0 <17"
"node": ">=18.17.0 <21"
},
"devDependencies": {
"@theia/cli": "1.39.0",
Expand Down

0 comments on commit bb4b145

Please sign in to comment.