Fix 2496 - umounting all partitions #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Torxed could you approve this to get it in :) |
Torxed
approved these changes
May 15, 2024
|
Good job! Approved and merged! |
|
Nice guys! Thanks a lot! |
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2496
I was able to reproduce the problem on the latest master and with this change it seems to be fixed.
The problem is that during the partitioning/formatting the
umount_all_existingis called multiple times, even after existing partitions have been deleted already which results in trying to umount these deleted partitions as a old reference object is used.There shouldn't be any need to call the umount each time a partitioning or formatting is performed but only once for each disk involved.