Adds dosfstools to the PKGBUILD depends #2439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the tools needed by archinstall is mkfs.fatXX and this wasn't automatically installed.
PR Description:
This adds dosfstools, which provides the mkfs.fat binary which is used in device_handler.py
Tests and Checks
When I run
makepkg -s
on my system with or without this change, I receive an error that my build did not pass the "validity check". I don't know if this has bearing on the integrity of this change, so I left the following checklist for what I believe would be a good test of this change.pacman -S archinstall
and try to format any partition using a code path that relies on mkfs.fat, archinstall will error because this tool is not installed.makepkg -si
, dosfstools was installed on my system along with archinstall.