Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a form to move notes to other folders. #231

Merged
merged 10 commits into from May 21, 2021
Merged

Conversation

edditler
Copy link
Contributor

@edditler edditler commented May 8, 2021

Could also be used to address this issue #223.

Bildschirmfoto 2021-05-08 um 10 36 54

@edditler
Copy link
Contributor Author

edditler commented May 8, 2021

There is a Path attribute in the front matter. Is it possible to reuse the api.update_dataobj_frontmatter to change that too? I don't think the attribute is used anywhere in the code.

@Uzay-G
Copy link
Member

Uzay-G commented May 8, 2021

I think it's best if we deprecate that attribute, it's a bit redundant.

archivy/data.py Outdated Show resolved Hide resolved
@edditler
Copy link
Contributor Author

edditler commented May 8, 2021

I think it's best if we deprecate that attribute, it's a bit redundant.

Should we do that in this PR or another one?

@edditler
Copy link
Contributor Author

edditler commented May 8, 2021

I was a bit surprised about the from shutils import .... Maybe it's better to just import shutils so that it's clear that those function operate on files.

@Uzay-G
Copy link
Member

Uzay-G commented May 8, 2021

Yeah good idea.

@Uzay-G
Copy link
Member

Uzay-G commented May 8, 2021

I think it's best if we deprecate that attribute, it's a bit redundant.

Should we do that in this PR or another one?

Yeah don't worry about it.

@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #231 (05d6d2a) into master (fa1de98) will increase coverage by 0.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   82.82%   83.44%   +0.62%     
==========================================
  Files          27       27              
  Lines        2026     2084      +58     
==========================================
+ Hits         1678     1739      +61     
+ Misses        348      345       -3     
Impacted Files Coverage Δ
archivy/data.py 92.34% <100.00%> (+1.48%) ⬆️
archivy/forms.py 100.00% <100.00%> (ø)
archivy/routes.py 90.47% <100.00%> (+1.58%) ⬆️
tests/functional/test_routes.py 100.00% <100.00%> (ø)
conftest.py 90.00% <0.00%> (+0.14%) ⬆️
archivy/__init__.py 61.53% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa1de98...05d6d2a. Read the comment docs.

@Uzay-G
Copy link
Member

Uzay-G commented May 20, 2021

@edditler I made some changes to the design (see below) and refactored some stuff. Does this design work for you (a bit simpler):
image

@Uzay-G
Copy link
Member

Uzay-G commented May 20, 2021

Alright I also added some tests! Once I have your go I'll merge this in :)

Copy link
Contributor Author

@edditler edditler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@Uzay-G Uzay-G merged commit 06b0c44 into archivy:master May 21, 2021
@Uzay-G
Copy link
Member

Uzay-G commented May 21, 2021

Perfect :)

I'll make a new release soon, once the other open PRs are sorted.

@edditler edditler deleted the move_files branch May 21, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants