New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a form to move notes to other folders. #231
Conversation
There is a |
I think it's best if we deprecate that attribute, it's a bit redundant. |
Should we do that in this PR or another one? |
I was a bit surprised about the |
Yeah good idea. |
Yeah don't worry about it. |
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 82.82% 83.44% +0.62%
==========================================
Files 27 27
Lines 2026 2084 +58
==========================================
+ Hits 1678 1739 +61
+ Misses 348 345 -3
Continue to review full report at Codecov.
|
@edditler I made some changes to the design (see below) and refactored some stuff. Does this design work for you (a bit simpler): |
Alright I also added some tests! Once I have your go I'll merge this in :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, thanks!
Perfect :) I'll make a new release soon, once the other open PRs are sorted. |
Could also be used to address this issue #223.