feat: add locale header to request to fetch content based on system locale if possible #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srevinsaju
force-pushed
the
l10n-requests
branch
from
04c4c15
to
9a39260
Compare
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 82.01% 82.68% +0.66%
==========================================
Files 27 27
Lines 1763 1808 +45
==========================================
+ Hits 1446 1495 +49
+ Misses 317 313 -4
Continue to review full report at Codecov.
|
|
ping for a merge. |
Uzay-G
reviewed
Feb 22, 2021
srevinsaju
force-pushed
the
l10n-requests
branch
from
9a39260
to
58c9e40
Compare
Uzay-G
reviewed
Feb 22, 2021
| @@ -92,7 +93,15 @@ def process_bookmark_url(self): | |||
| return None | |||
|
|
|||
| try: | |||
| url_request = requests.get(self.url) | |||
| try: | |||
| lc = locale.getdefaultlocale()[0].replace('_', '-') | |||
There was a problem hiding this comment.
Does this work for every locale (replacing _ with -)?
There was a problem hiding this comment.
I hope it works, is there any case it doesnt?
There was a problem hiding this comment.
I'm not sure, I don't know much about locales and how it works with web requests, so I was asking since you opened the PR.
I just want to make sure the code we merge in works well :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #176