fix: 'archivy init' does not purge old configuration before interactive init #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve init archivy does not reset the configuration before creating the new user. This is because archivy calls click.create_admin before resetting the configuration. It is also recommended to purge the configuration, (and not replace existing conf), to remove old entries along with this patch, a new value, VERSION would be added to the configuration which would be useful in future to migrate old configuration to new configuration tree.
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 81.22% 81.25% +0.03%
==========================================
Files 27 27
Lines 1704 1707 +3
==========================================
+ Hits 1384 1387 +3
Misses 320 320
Continue to review full report at Codecov.
|
…t in archivy init previously, archivy, when running 'archivy init' never asked the user if they would like to remove the old users, i.e db.json. It would be useful to ask the user if they would like to remove them
Uzay-G
reviewed
Dec 31, 2020
| remove_old_users = click.confirm("Found an existing user database. Do you want " | ||
| "to remove them?") | ||
| if remove_old_users: | ||
| users_db.unlink() |
There was a problem hiding this comment.
This would also remove other db objects. Maybe we can just inform them there are other created users and provide a delete-user command?
There was a problem hiding this comment.
What other information can the db contain?
Uzay-G
reviewed
Dec 31, 2020
|
|
||
| class Config(object): | ||
| """Configuration object for the application""" | ||
|
|
||
| VERSION = VERSION |
There was a problem hiding this comment.
Maybe we can directly define it as VERSION = 1 here?
|
Sorry, posted that at the wrong place 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
archivy does not reset the configuration before creating the new user.
This is because archivy calls click.create_admin before resetting the configuration.
It is also recommended to purge the configuration, (and not replace existing conf), to
remove old entries
along with this patch, a new value, VERSION would be added to the configuration
which would be useful in future to migrate old configuration to new configuration tree.