Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to 1.20.6 #494

Merged
merged 14 commits into from
May 18, 2024
Merged

Port to 1.20.6 #494

merged 14 commits into from
May 18, 2024

Conversation

Jab125
Copy link
Member

@Jab125 Jab125 commented Apr 27, 2024 •
edited

  • Fabric
  • NeoForge

Should be a very quick port.

@shedaniel
Copy link
Member

Do we need a port? Doesn't it just works?

@Jab125
Copy link
Member Author

Jab125 commented Apr 27, 2024

Do we need a port? Doesn't it just works?

We'll have to port in the future anyways, since I doubt NeoForge would keep maintaining 20.5 after 1.20.6 is released.

@Jab125 Jab125 added priority: low This does not immediately need to be resolved 1.20 This issue applies to Minecraft 1.20. labels Apr 27, 2024
@shedaniel
Copy link
Member

Yeah don't worry about that for now, we/I can do that when that's needed, we do that for older similar versions too

@Jab125 Jab125 added priority: medium This issue or PR should be worked on soon-ish and removed priority: low This does not immediately need to be resolved labels Apr 29, 2024
@Jab125 Jab125 marked this pull request as ready for review May 10, 2024 12:54
@Jab125 Jab125 requested a review from shedaniel May 10, 2024 12:54
@Jab125
Copy link
Member Author

Jab125 commented May 10, 2024

I've also fixed a bug with void acceptAfter(ItemStack after, ItemStack stack, CreativeModeTab.TabVisibility visibility); and void acceptBefore(ItemStack before, ItemStack stack, CreativeModeTab.TabVisibility visibility); where on NeoForge, it was unable to actually place items in the correct locations.

@Jab125
Copy link
Member Author

Jab125 commented May 10, 2024

Also requesting the creation of a 1.20.6 branch to merge this into.

@Juuxel Juuxel mentioned this pull request May 11, 2024
Merged
@Jab125 Jab125 mentioned this pull request May 12, 2024
Closed
@shedaniel shedaniel changed the base branch from 1.20.5 to 1.20.6 May 18, 2024 12:29
@shedaniel shedaniel merged commit ba78f46 into architectury:1.20.6 May 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shedaniel shedaniel shedaniel approved these changes

Assignees
No one assigned
Labels
1.20 This issue applies to Minecraft 1.20. priority: medium This issue or PR should be worked on soon-ish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jab125 @shedaniel