Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: hide keyboard when showing spinner options #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balakzde
Copy link

@balakzde balakzde commented Dec 5, 2019

Hide keyboard when showing options.

Use case:

  • I have focus in edittext with opened keyboard
  • When opening spinners options keyboard won't disappear and I am able to type
  • Focus is still on edittext but text is not changing

This is not very nice behaviour

  • When doing this on one plus 7 (with their gestures instead of the navigation buttons on bottom) everything freezes and I am not able to open keyboard again until I kill the app

This is critical issue

@@ -30,7 +31,6 @@
import android.widget.ListPopupWindow;
import android.widget.ListView;

import java.util.ArrayList;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Was this part of an "Optimize imports" action? are there more unused imports in this file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and no, there are not any more unused imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants