cURL for internal requests #20864
Closed
cURL for internal requests #20864
+1,370
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ics-network-connection-pool
…connection-pool' into feature/curl-cluster-comm
|
Curl is simply too slow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Instead of rolling our own http2 client, we use curl, which supports multiplexing via http2 and connection pools. This allows us to remove a lot of our (not soo reliable) network code.
This PR is a proof of concept: it quickly hacks in curl at the lowest level and hands over all network requests to the library. After we ran tests and performance analysis, I will put more effort into remove the old code and all traces of fuerte.