New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed size ThreadPool scheduler #20808
Open
maierlars
wants to merge
52
commits into
devel
Choose a base branch
from
feature/thread-pool-scheduler
base: devel
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maierlars
force-pushed
the
feature/thread-pool-scheduler
branch
from
April 3, 2024 13:15
f9a3e4e
to
35d0162
Compare
maierlars
force-pushed
the
feature/thread-pool-scheduler
branch
from
April 4, 2024 10:23
35d0162
to
d2994c5
Compare
goedderz
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soo much simpler 😍
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
reviewed
May 23, 2024
jsteemann
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
This PR implements a new
ThreadPoolScheduler
with a fixed number of threads, and a number of different thread pools. TheThreadPoolScheduler
creates a separate thread pool for each priority lane.We have the following thread pools:
This PR also implements a number of synthetic benchmarks as tests (by default these are disabled so that they do not run durng regular builds). These benchmarks showed, that the WorkStealingThreadPool scales significantly better than the other two thread pools, and also much better then the current SupervisedScheduler.