Fix: Type 'string[]' is not assignable to type 'string | I18nDictionary'. #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aralroca
approved these changes
Sep 22, 2022
|
@mkbctrl thanks for your contribution 👍 |
|
Tests are failing in this line of code: https://github.com/aralroca/next-translate/blob/canary/src/transCore.tsx#L115 Would you please try to correct it? thanks! |
|
sure, will have a look at it soon
…On Thu, 22 Sep 2022 at 10:21, Aral Roca Gomez ***@***.***> wrote:
Tests are failing in this line of code:
https://github.com/aralroca/next-translate/blob/canary/src/transCore.tsx#L115
Would you please try to correct it? thanks!
—
Reply to this email directly, view it on GitHub
<#926 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACNDTYRBI4N2HVHZN2NPAMTV7QJHJANCNFSM6AAAAAAQSGOOOU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
update: got super busy in my project, didn't forget about it. It's still on my todo |
aralroca
approved these changes
Feb 20, 2023
|
@mkbctrl just a ping for this 👍 BTW; thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
What changes did you make? (Give an overview)
Added
string[]toI18nDictionaryinterfaceWhich issue (if any) does this pull request address?
#925
Is there anything you'd like reviewers to focus on?
No, not really