Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto3 & expr.Expr json #205

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Proto3 & expr.Expr json #205

wants to merge 6 commits into from

Conversation

araddon
Copy link
Owner

@araddon araddon commented Dec 24, 2017

The goal of this pr is two-fold

TODO

  • verify downstream usage won't break

@codecov-io
Copy link

codecov-io commented Dec 24, 2017

Codecov Report

Merging #205 into master will decrease coverage by 0.68%.
The diff coverage is 65.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   68.12%   67.43%   -0.69%     
==========================================
  Files          87       87              
  Lines       16192    16741     +549     
==========================================
+ Hits        11030    11289     +259     
- Misses       4310     4535     +225     
- Partials      852      917      +65
Impacted Files Coverage Δ
plan/plan.go 44.4% <25%> (-1.39%) ⬇️
expr/node.go 52.63% <66.32%> (-1.37%) ⬇️
rel/sql.go 45.81% <73.33%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01687b6...f0d1ce7. Read the comment docs.

@araddon araddon changed the title Proto3 Proto3 & expr.Expr json Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants