Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add environment variable CABOT_RESULTS_RETENTION_DAYS #669

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thomasleveil
Copy link
Contributor

This pull requests allows to change the number of days for data retention by setting the CABOT_RESULTS_RETENTION_DAYS environment variable.

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #669 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #669   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files          46       46           
  Lines        2955     2955           
  Branches      179      179           
=======================================
  Hits         2391     2391           
  Misses        505      505           
  Partials       59       59           
Impacted Files Coverage Δ
cabot/cabotapp/views.py 70.89% <ø> (ø)
cabot/celery.py 100.00% <ø> (ø)
cabot/settings.py 68.42% <ø> (ø)
cabot/cabotapp/tasks.py 61.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf8cb7...f9d043f. Read the comment docs.

Copy link
Contributor

@dbuxton dbuxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small request

cabot/cabotapp/tasks.py Show resolved Hide resolved
@s7anley
Copy link

s7anley commented Jul 14, 2020

Hey @dbuxton 👋 Any chance this could get merged and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants