Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Maximum call stack size exceeded" error #111

Merged
merged 1 commit into from Jul 1, 2018

Conversation

rfletcher
Copy link
Contributor

Running cloudsploit/scans master (c11a6fd) against a large AWS account, I consistently encounter this error:

node ./cloudsploit/index.js

./cloudsploit/node_modules/aws-sdk/lib/request.js:31
            throw err;
            ^

RangeError: Maximum call stack size exceeded
    at ./cloudsploit/node_modules/async/dist/async.js:3339:20
    at replenish (./cloudsploit/node_modules/async/dist/async.js:836:21)
    at ./cloudsploit/node_modules/async/dist/async.js:846:15
    at eachLimit (./cloudsploit/node_modules/async/dist/async.js:3344:35)
    at Object.<anonymous> (./cloudsploit/node_modules/async/dist/async.js:874:20)
    at Object.run (./cloudsploit/plugins/rds/rdsAutomatedBackups.js:31:9)
    at ./cloudsploit/index.js:85:16
    at replenish (./cloudsploit/node_modules/async/dist/async.js:836:21)
    at ./cloudsploit/node_modules/async/dist/async.js:842:29
    at ./cloudsploit/node_modules/async/dist/async.js:804:16

Searching around a bit, it seems to fit the description in this async issue: caolan/async#75. The recommendation there is to make sure you're using async asynchronously. With that in mind, this patch seems to fix things for me.

I don't know async or Cloudsploit well, so I don't know whether this is the best place for this fix, but I can run the scan without error now.

@tylerwengerd-cr
Copy link

Making this change worked for me, thanks

@matthewdfuller
Copy link
Contributor

Thanks @rfletcher for submitting this and @tylerwengerd-cr for verifying! Merging in now.

@matthewdfuller matthewdfuller merged commit c04d54c into aquasecurity:master Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants