Fix "Maximum call stack size exceeded" error #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running cloudsploit/scans master (c11a6fd) against a large AWS account, I consistently encounter this error:
Searching around a bit, it seems to fit the description in this async issue: caolan/async#75. The recommendation there is to make sure you're using async asynchronously. With that in mind, this patch seems to fix things for me.
I don't know async or Cloudsploit well, so I don't know whether this is the best place for this fix, but I can run the scan without error now.