Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: server side rendering #11

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

feat: server side rendering #11

wants to merge 15 commits into from

Conversation

loks0n
Copy link
Collaborator

@loks0n loks0n commented Jan 23, 2024

Meldiron
Meldiron requested changes Jan 24, 2024
View reviewed changes
server-side-rendering/.env.example Show resolved Hide resolved
server-side-rendering/LICENSE Outdated Show resolved Hide resolved
server-side-rendering/README.md Outdated Show resolved Hide resolved
server-side-rendering/README.md Outdated Show resolved Hide resolved
server-side-rendering/README.md Show resolved Hide resolved
server-side-rendering/src/routes/+page.svelte Outdated Show resolved Hide resolved
server-side-rendering/src/routes/+page.server.ts Outdated Show resolved Hide resolved
server-side-rendering/src/routes/+layout.server.ts Show resolved Hide resolved
server-side-rendering/src/routes/api/auth/+server.ts Outdated Show resolved Hide resolved
server-side-rendering/src/routes/signin/+page.svelte Outdated Show resolved Hide resolved
@loks0n loks0n requested a review from Meldiron January 30, 2024 13:34
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
gewenyu99
gewenyu99 requested changes Mar 9, 2024
View reviewed changes
Copy link

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add some basic error handling here?

server-side-rendering/package.json Outdated Show resolved Hide resolved
server-side-rendering/src/routes/signin/+page.svelte Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewenyu99 gewenyu99 gewenyu99 requested changes

@divanov11 divanov11 Awaiting requested review from divanov11

@Meldiron Meldiron Awaiting requested review from Meldiron

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loks0n @Meldiron @gewenyu99