[FEATURE] - Configuration Rate Limiting #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the controller will attempt to reconcile all Configurations when a change is detected. In small scale deployments this is not an issue, but where there is a large number of Configurations this can cause a large number of API calls, and potentially cause rate limiting to be applied. This change adds a `--configuration-threshold <float64>` e.g to say only 10 percents of jobs can run at any one time `--configuration-threshold 0.1`. When a Configuration is deferred due to rate limiting, the `ConditionReady` is set to false and a warning message is appended to the `Status.Conditions` field.
|
cc @KashifSaadat … can I have a quick review please :-) |
cezarsa
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the controller will attempt to reconcile all Configurations when a change is detected. In small scale deployments this is not an issue, but where there is a large number of Configurations this can cause a large number of API calls, and potentially cause rate limiting to be applied. This change adds a
--configuration-threshold <float64>e.g to say only 10 percents of jobs can run at any one time--configuration-threshold 0.1.When a Configuration is deferred due to rate limiting, the
ConditionReadyis set to false and a warning message is appended to theStatus.Conditionsfield.