adding support for calling the public branding APIs from the SDK. #74
Conversation
karikittie
requested review from
chances,
SamOrozco,
matthewtsmith and
alexisandreason
|
|
||
| public static CompletionStage<Branding> getBranding(String appId, String version, String os) { | ||
| WSRequest request; | ||
| String routerUrl = "https://go-monolith-v2-sbx.herokuapp.com"; |
There was a problem hiding this comment.
The router URL should be parameterized, or otherwise configurable
|
|
||
| public static CompletionStage<Branding> getBranding(String appId, String version) { | ||
| return getBranding(appId, version, "https://go-monolith-v2-sbx.herokuapp.com"); | ||
| } |
There was a problem hiding this comment.
The url should be configurable rather than hard coded. The default should be go-monolith-v2.herokuapp.com.
There was a problem hiding this comment.
pushed the constant string into Constants.java
| * Date: 11/22/17 | ||
| */ | ||
|
|
||
| public class BrandingConfiguration { |
There was a problem hiding this comment.
You should consider adding @JsonIgnoreProperties(ignoreUnknown = true) If the response changes it will break this request.
| } | ||
|
|
||
| JsonNode json = wsResponse.asJson(); | ||
| return Optional.ofNullable(JsonUtils.fromJson(json, Branding.class)).orElse(null); |
There was a problem hiding this comment.
Doesn't Optional.ofNullable return value if not null or Optional.empty() if it is null? I'm not sure why you need orElse(null)
app/sdk/utils/Constants.java
Outdated
| @@ -34,4 +35,6 @@ | |||
| public static final String UPDATED_DATE_PARAM = "updatedate"; | |||
|
|
|||
| public static final String AllowedOffsetKey = "apptree.allowedServerOffset"; | |||
|
|
|||
| public static final String BRANDING_ROUTER_URL = "https://go-monolith-v2-sbx.herokuapp.com"; | |||
There was a problem hiding this comment.
Rename this to ROUTER_URL.
Shouldn't the default be https://go-monolith-v2.herokuapp.com?
Gets all branding information from the public API.