chore: Add test case for FireStorePlugin pagination using where clause

[rishabhrathod01]

Description

Adding JUnit test case for firestore plugin pagination with where clause

Fixes #33007

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9013682301
Commit: ea10b7b
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

[coderabbitai]

Walkthrough

Walkthrough

The changes in the Firestore plugin primarily involve enhancing the functionality of action configurations and pagination handling within the unit tests. These modifications include the addition of a 'limit' parameter to functions that construct action configurations and fetch pagination data, aligning with the need to handle queries more precisely in test scenarios.

Changes

File Path	Change Summary
.../firestorePlugin/src/test/java/.../FirestorePluginTest.java	Added 'limit' parameter to constructActionConfiguration and getNextOrPrevPage methods.

Assessment against linked issues

Objective	Addressed	Explanation
Add JUnit test for firestore plugin for startAfter with where clause (#33007)	❓	The changes suggest an update to test configurations, but it's unclear if a specific test for "startAfter with where clause" has been added. Further review of the test cases is needed to confirm.

The modifications in the test methods suggest a preparation or enhancement towards testing more specific query scenarios, possibly including the "startAfter with where clause". However, without explicit evidence of a new test case addressing this exact scenario, it remains uncertain if the objective is fully met.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 629f44a and ea10b7b.

Files selected for processing (1)

• app/server/appsmith-plugins/firestorePlugin/src/test/java/com/external/plugins/FirestorePluginTest.java (4 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/server/appsmith-plugins/firestorePlugin/src/test/java/com/external/plugins/FirestorePluginTest.java

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Failed server tests

• com.external.plugins.FirestorePluginTest#testPaginationWithWhereConditional

[NilanshBansal]

server-unit-tests are failing. Can you pls check @rishabhrathod01
#33294 (comment)