Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: git auto generate header issue fixed #33016

Merged
merged 1 commit into from
Apr 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export const DEFAULT_API_ACTION_CONFIG: ApiActionConfig = {
httpVersion: DEFAULT_HTTP_VERSION_TYPE,
headers: EMPTY_KEY_VALUE_PAIRS.slice(),
queryParameters: EMPTY_KEY_VALUE_PAIRS.slice(),
autoGeneratedHeaders: [],
body: "",
bodyFormData: [],
formData: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export const DEFAULT_GRAPHQL_ACTION_CONFIG: ApiActionConfig = {
formData: {
apiContentType: POST_BODY_FORMAT_OPTIONS.JSON,
},
autoGeneratedHeaders: [],
pluginSpecifiedTemplates: [
{
// JSON smart substitution
Expand Down
52 changes: 52 additions & 0 deletions app/client/src/sagas/__tests__/ApiPaneSagas.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import type { CreateApiActionDefaultsParams } from "entities/Action";
import { createDefaultApiActionPayload } from "sagas/ApiPaneSagas";

describe("tests the sagas in ApiPaneSagas", () => {
const inputPayload: CreateApiActionDefaultsParams = {
apiType: "graphql-plugin",
newActionName: "newName",
};

it("1. Bug 27941: Tests createDefaultApiActionPayload to return prepopulated empty array for autoGeneratedHeaders", function () {
const outputPayloadGenerator: Generator =
createDefaultApiActionPayload(inputPayload);

// Mocking getCurrentWorkspaceId selector
const workspaceIdSelectorEffect = outputPayloadGenerator.next().value;
workspaceIdSelectorEffect.payload.selector = jest.fn();
workspaceIdSelectorEffect.payload.selector.mockReturnValue(
"testWorkspaceId",
);

// Mock getPluginIdOfPackageName selector
const pluginIdSelectorEffect = outputPayloadGenerator.next().value;
pluginIdSelectorEffect.payload.selector = jest.fn();
pluginIdSelectorEffect.payload.selector.mockReturnValue("pluginId");

// Get actionconfig value now
const outputPayload = outputPayloadGenerator.next().value;
expect(outputPayload?.actionConfiguration.autoGeneratedHeaders).toEqual([]);
});

it("2. Bug 27941: Tests createDefaultApiActionPayload to return prepopulated empty array for autoGeneratedHeaders", function () {
inputPayload.apiType = "restapi-plugin";
const outputPayloadGenerator: Generator =
createDefaultApiActionPayload(inputPayload);

// Mocking getCurrentWorkspaceId selector
const workspaceIdSelectorEffect = outputPayloadGenerator.next().value;
workspaceIdSelectorEffect.payload.selector = jest.fn();
workspaceIdSelectorEffect.payload.selector.mockReturnValue(
"testWorkspaceId",
);

// Mock getPluginIdOfPackageName selector
const pluginIdSelectorEffect = outputPayloadGenerator.next().value;
pluginIdSelectorEffect.payload.selector = jest.fn();
pluginIdSelectorEffect.payload.selector.mockReturnValue("pluginId");

// Get actionconfig value now
const outputPayload = outputPayloadGenerator.next().value;
expect(outputPayload?.actionConfiguration.autoGeneratedHeaders).toEqual([]);
});
});