[WIP] Feature branch for removing default resources

[nidhi-nair]

Fixes #32877

Counterpart to https://github.com/appsmithorg/appsmith-ee/pull/4056

Summary by CodeRabbit

Summary by CodeRabbit

• Refactor
  • Updated several classes to extend GitSyncedDomain for enhanced Git synchronization capabilities.
• Bug Fixes
  • Simplified processing in ApplicationImportServiceCEImpl by removing redundant operations on CustomJSLib objects.
• New Features
  • Introduced a new class GitSyncedDomain to support syncing across instances using Git.
• Documentation
  • Removed deprecated gitSyncId field from BaseDomain to streamline class structure.
• Chores
  • Adjusted database indices to align with the new GitSyncedDomain structure in DatabaseChangelog2.

[coderabbitai]

Walkthrough

The modifications primarily focus on restructuring the inheritance and simplification of domain models within the codebase. Key changes include the removal of the gitSyncId field from BaseDomain and the introduction of GitSyncedDomain to centralize Git-related properties. Several classes have been updated to adjust their inheritance to either BaseDomain or GitSyncedDomain, reflecting a shift towards more explicit Git synchronization management across different domains.

Changes

File Path	Change Summary
.../models/BaseDomain.java	Removed gitSyncId field and related annotations.
.../models/BranchAwareDomain.java, .../models/Datasource.java, .../models/DatasourceStorage.java	Updated inheritance to GitSyncedDomain.
.../models/GitSyncedDomain.java	Introduced new class GitSyncedDomain extending BaseDomain with gitSyncId.
.../imports/ApplicationImportServiceCEImpl.java, .../imports/importable/artifactbased/ArtifactBasedImportableServiceCE.java	Simplified handling of CustomJSLib entities and enhanced logic for entity retrieval based on GitSyncedDomain.
.../server/domains/ce/CustomJSLibCE.java	Changed inheritance from BranchAwareDomain to BaseDomain.
.../migrations/DatabaseChangelog2.java	Updated index creation references from BaseDomain.Fields.gitSyncId to GitSyncedDomain.Fields.gitSyncId.

Assessment against linked issues

Objective	Addressed	Explanation
Remove default resource references across domains (#32877)	❌	The changes primarily focus on inheritance and Git synchronization management, but do not explicitly address the removal of default resource references across domains as described in the linked issue.

The assessment indicates that while the changes streamline the codebase around Git synchronization, they do not directly address the specific objective of removing default resource references across domains. More targeted modifications might be required to fully achieve this goal.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.