New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor isCurrentWidgetFocused
to isWidgetFocused
#32990
Conversation
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
…o refactor/selected-widget-selector
WalkthroughWalkthroughThe primary modification across various components and hooks in the Anvil layout system involves renaming the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
isCurrentWidgetFocused
to isWidgetFocused
isCurrentWidgetFocused
to isWidgetFocused
Description
We pass the
widgetId
to a function check if the widget is focused. This function is mislabeled asisCurrentWidgetFocused
. TheCurrent
assumes that the widget is available in context.A better name would be
isWidgetFocused
.This PR refactors to rectify this.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8960937874
Commit: 2126e29
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?