Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor isCurrentWidgetFocused to isWidgetFocused #32990

Merged
merged 4 commits into from May 6, 2024

Conversation

riodeuno
Copy link
Contributor

@riodeuno riodeuno commented Apr 26, 2024

Description

We pass the widgetId to a function check if the widget is focused. This function is mislabeled as isCurrentWidgetFocused. The Current assumes that the widget is available in context.
A better name would be isWidgetFocused.

This PR refactors to rectify this.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8960937874
Commit: 2126e29
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@riodeuno riodeuno self-assigned this Apr 26, 2024
Copy link

github-actions bot commented May 3, 2024

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label May 3, 2024
@riodeuno riodeuno added Anvil POD Issue related to Anvil project Anvil team issues related to the new layout system anvil and removed Stale labels May 5, 2024
@riodeuno riodeuno marked this pull request as ready for review May 5, 2024 20:27
@riodeuno riodeuno requested a review from a team as a code owner May 5, 2024 20:27
@riodeuno riodeuno added the ok-to-test Required label for CI label May 5, 2024
Copy link
Contributor

coderabbitai bot commented May 5, 2024

Walkthrough

Walkthrough

The primary modification across various components and hooks in the Anvil layout system involves renaming the isCurrentWidgetFocused function to isWidgetFocused. This change standardizes the function name related to widget focus across multiple files, enhancing consistency and clarity in the codebase. The renaming affects import statements and function usage, impacting how widget focus is determined and handled throughout the application.

Changes

Files Change Summary
.../useWidgetBorderStyles.ts, .../AnvilWidgetName/selectors.ts, .../useAnvilWidgetClick.ts, .../useAnvilWidgetDrag.ts, .../useAnvilWidgetHover.ts, .../DraggableComponent.tsx, .../ResizableComponent.tsx, .../widgetName/index.tsx, .../widgetSelectors.ts, .../useClickToSelectWidget.tsx, .../useHoverToFocusWidget.ts Renamed isCurrentWidgetFocused to isWidgetFocused and updated its usage across various files.
.../useWidgetBorderStyles.ts Updated import statements and selector functions usage.
.../DraggableComponent.tsx, .../widgetName/index.tsx Modified import statements and function usage for consistency.
.../ResizableComponent.tsx Renamed a variable to avoid naming conflicts post function renaming.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2126e29 and ac4383c.
Files selected for processing (2)
  • app/client/src/layoutSystems/anvil/editor/AnvilWidgetName/selectors.ts (2 hunks)
  • app/client/src/layoutSystems/common/resizer/ResizableComponent.tsx (5 hunks)
Files skipped from review as they are similar to previous changes (2)
  • app/client/src/layoutSystems/anvil/editor/AnvilWidgetName/selectors.ts
  • app/client/src/layoutSystems/common/resizer/ResizableComponent.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@riodeuno riodeuno changed the title Refactor: isCurrentWidgetFocused to isWidgetFocused feat: Refactor isCurrentWidgetFocused to isWidgetFocused May 5, 2024
@github-actions github-actions bot added the Enhancement New feature or request label May 5, 2024
marks0351
marks0351 previously approved these changes May 6, 2024
KelvinOm
KelvinOm previously approved these changes May 6, 2024
@riodeuno riodeuno dismissed stale reviews from KelvinOm and marks0351 via ac4383c May 6, 2024 07:49
@riodeuno riodeuno requested a review from marks0351 May 6, 2024 07:49
@riodeuno riodeuno merged commit a490128 into release May 6, 2024
13 checks passed
@riodeuno riodeuno deleted the refactor/selected-widget-selector branch May 6, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anvil POD Issue related to Anvil project Anvil team issues related to the new layout system anvil Enhancement New feature or request ok-to-test Required label for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants