fix: update custom color picker button

[jsartisan]

Fixes #31959
Tiny UX update to the custom color picker button in WDS theme settings.

Summary by CodeRabbit

• New Features
  • Enhanced the theme property pane to identify and display custom accent colors differently.
• Style Updates
  • Improved alignment and visual presentation of buttons and labels in the theme property pane.
  • Added new styles for SVG paths to enhance visual clarity.

[coderabbitai]

Walkthrough

The recent updates focus on enhancing the user interface of the WDSThemePropertyPane component by introducing logic to identify custom accent colors and adjusting UI elements accordingly. Additionally, the styling of buttons, labels, and SVG paths has been refined to improve visual alignment and aesthetics within the component.

Changes

File Path	Change Summary
.../Editor/WDSThemePropertyPane/index.tsx .../Editor/WDSThemePropertyPane/styles.module.css	Introduced logic for custom accent color detection, updated UI elements based on custom color condition, and enhanced alignment and styling of buttons, labels, and SVG paths for improved visual aesthetics.

Possibly related issues

• github/bug: WDS modal background overlay color is too light with light seeds (light mode) #32428: The changes in this PR address the need to ensure visual distinctiveness and readability of the background overlay color in the WDS modal, aligning with the design theme and color scheme while testing across various devices for effectiveness.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Update the conditional rendering logic for clarity.

The conditional rendering in the label can be simplified for better readability. Consider using a ternary operator or extracting this logic into a small render function.

- {isCustomColor === false && (
-   <Icon color="white" name="check-line" size="md" />
- )}
+ {!isCustomColor && <Icon color="white" name="check-line" size="md" />}

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	<label
	data-selected={isCustomColor === false ? "" : undefined}
	htmlFor="color-picker"
	style={{ color: theme.accentColor }}
	>
	{isCustomColor === false && (
	<Icon color="white" name="check-line" size="md" />
	)}
	<label
	data-selected={isCustomColor === false ? "" : undefined}
	htmlFor="color-picker"
	style={{ color: theme.accentColor }}
	>
	{!isCustomColor && <Icon color="white" name="check-line" size="md" />}

[KelvinOm]

Can we pass this as className? It is better to set such things directly. In the future, we may face unexpected behavior if we try to use some icons.

[jsartisan]

not sure what you are suggesting here 🤔 I mean how it will work with className

[jsartisan]

Added comment for above css.