Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating the login button names for OIDC & SAML to get it from tenant config #32979

Merged
merged 4 commits into from May 15, 2024

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Apr 26, 2024

Description

Updating the login button names for OIDC & SAML to get it from tenant config

Fixes #25660

Automation

/ok-to-test tags="@tag.Settings"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9073688267
Commit: f8c0454
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor

    • Improved admin settings management by removing redundant data fetching in the super user functionalities.
  • New Features

    • Enhanced third-party authentication by dynamically updating social login button labels based on tenant configurations.

Copy link
Contributor

coderabbitai bot commented Apr 26, 2024

Walkthrough

The updates primarily involve enhancing the user experience by allowing dynamic configuration of authentication interface elements. Specifically, the code changes remove unnecessary data fetching in the SuperUser settings and introduce dynamic label updates for social login buttons based on tenant configurations. This aligns with efforts to make the interface more intuitive and customizable for different tenant settings.

Changes

File Path Change Summary
.../src/ce/sagas/SuperUserSagas.tsx Removed unused import and function call to simplify admin settings management.
.../src/pages/UserAuth/ThirdPartyAuth.tsx Added utility imports and logic to dynamically update social login button labels based on configuration.

Assessment against linked issues

Objective Addressed Explanation
Allow instance admin to configure OIDC connection name (#25660) The changes in ThirdPartyAuth.tsx support dynamic label updates for authentication buttons, allowing customization of the OIDC connection name as described in the issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Billing & Usage Pod Issues pertaining to licensing, billing and usage across self serve and enterprise customers Enhancement New feature or request Frontend This label marks the issue or pull request to reference client code SSO Issues, requests and enhancements around Single sign-on. Team Managers Pod Issues that team managers care about for the security and efficiency of their teams TM_BU The issues on Team Manager which needs to be taken up by Billing & Usage skip-changelog Adding this label to a PR prevents it from being listed in the changelog and removed Enhancement New feature or request labels Apr 26, 2024
Copy link

github-actions bot commented May 3, 2024

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label May 3, 2024
@github-actions github-actions bot added the Enhancement New feature or request label May 8, 2024
@ankitakinger ankitakinger added the ok-to-test Required label for CI label May 14, 2024
@ankitakinger ankitakinger merged commit 62ffaf8 into release May 15, 2024
41 checks passed
@ankitakinger ankitakinger deleted the feat/custom-connection-name-oidc-saml branch May 15, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Billing & Usage Pod Issues pertaining to licensing, billing and usage across self serve and enterprise customers Enhancement New feature or request Frontend This label marks the issue or pull request to reference client code ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog SSO Issues, requests and enhancements around Single sign-on. Stale Team Managers Pod Issues that team managers care about for the security and efficiency of their teams TM_BU The issues on Team Manager which needs to be taken up by Billing & Usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow instance admin to configure OIDC connection name
2 participants