New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updating the login button names for OIDC & SAML to get it from tenant config #32979
Conversation
WalkthroughThe updates primarily involve enhancing the user experience by allowing dynamic configuration of authentication interface elements. Specifically, the code changes remove unnecessary data fetching in the SuperUser settings and introduce dynamic label updates for social login buttons based on tenant configurations. This aligns with efforts to make the interface more intuitive and customizable for different tenant settings. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
…o feat/custom-connection-name-oidc-saml
…o feat/custom-connection-name-oidc-saml
Description
Updating the login button names for OIDC & SAML to get it from tenant config
Fixes #25660
Automation
/ok-to-test tags="@tag.Settings"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9073688267
Commit: f8c0454
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Refactor
New Features