Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move to interface based projection as for columns with jsonb type record based projections does not work in PG #32909

Merged
merged 9 commits into from May 3, 2024

Conversation

abhvsn
Copy link
Contributor

@abhvsn abhvsn commented Apr 24, 2024

Description

  • Move away from record based projections to interface classes as record based projections does not work for jsonb column in PG branch.
  • Remove ID generation within testclass and let DB handle the generation to fix failing tests on the PG branch.

Automation

/ok-to-test tags="@tag.Sanity, @tag.GenerateCRUD, "@tag.Fork""

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8919248892
Commit: f43425a
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor
    • Updated the method for generating workspace names to enhance uniqueness and reliability.
  • Bug Fixes
    • Improved the updateCurrentUser method to update the current user based on their ID for accuracy.

Copy link
Contributor

coderabbitai bot commented Apr 24, 2024

Walkthrough

Walkthrough

The recent codebase modifications aim to enhance encapsulation and data access within the application. Changes include updating method calls to use getter methods for specific properties, ensuring proper encapsulation and data management across various classes and services.

Changes

File Path Change Summary
.../appsmith-server/src/main/java/com/appsmith/server/fork/internal/ApplicationForkingServiceCEImpl.java
.../appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationPageServiceCEImpl.java
Updated method calls to use getter methods for id and policies properties, enhancing encapsulation and data access.
.../appsmith-server/src/main/java/com/appsmith/server/projections/IdPoliciesOnly.java Added @Getter annotation to the policies field in the IdPoliciesOnly record for improved data access.
.../appsmith-server/src/test/java/com/appsmith/server/services/UserWorkspaceServiceUnitTest.java Optimized workspace name generation using UUID.randomUUID().toString() for dynamic and unique names.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bc9836e and f43425a.
Files selected for processing (3)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/fork/internal/ApplicationForkingServiceCEImpl.java (2 hunks)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/projections/IdPoliciesOnly.java (1 hunks)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationPageServiceCEImpl.java (2 hunks)
Files skipped from review as they are similar to previous changes (3)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/fork/internal/ApplicationForkingServiceCEImpl.java
  • app/server/appsmith-server/src/main/java/com/appsmith/server/projections/IdPoliciesOnly.java
  • app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationPageServiceCEImpl.java

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Apr 24, 2024
Copy link

Failed server tests

  • com.appsmith.server.solutions.ApplicationForkingServiceTests#cloneApplicationForkWithConfigurationFalseWithActionsThrice

@abhvsn abhvsn changed the title chore: Remove redundant ids from while generating dummy workspaces chore: Add getter for policies field to reduce the diff between PG branch Apr 29, 2024
@abhvsn abhvsn requested a review from sharat87 April 29, 2024 08:00
@abhvsn abhvsn added the ok-to-test Required label for CI label Apr 29, 2024
@abhvsn abhvsn changed the title chore: Add getter for policies field to reduce the diff between PG branch chore: Move to interface based projection as for columns with jsonb type record based projections does not work in PG May 2, 2024
@abhvsn abhvsn added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 2, 2024
@abhvsn abhvsn requested a review from vivonk May 3, 2024 08:35
@abhvsn abhvsn merged commit bea3cc1 into release May 3, 2024
48 checks passed
@abhvsn abhvsn deleted the chore/remove-redundant-predefined-ids branch May 3, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants