Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Load OAuth2 configurations dynamically #22941

Draft
wants to merge 13 commits into
base: release
Choose a base branch
from

Conversation

sharat87
Copy link
Member

@sharat87 sharat87 commented May 3, 2023

This PR will load OAuth2 configurations for Google and GitHub dynamically, instead of having Spring pick them up statically at startup.

Why do we need this?

  1. This will enable us change OAuth2 configuration without needing a restart from Admin Settings.
  2. This will lead us towards being able to load the client-id and client-secret from the database, instead-of/in-addition-to the environment variables.
  3. Allow us to have separate OAuth2 configurations for separate tenants, in a multi-tenant setup.

Note that this only contains backend changes, and the client still requests a restart, although it's not required. I'll change client's behaviour there in a separate PR. This one, doesn't break any API contract.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label May 3, 2023
@sharat87
Copy link
Member Author

sharat87 commented May 3, 2023

/ok-to-test

@github-actions
Copy link

github-actions bot commented May 3, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4869567675.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22941.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22941&runId=4869567675_1

@github-actions
Copy link

github-actions bot commented May 3, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4869567675.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts

  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/LeaveWorkspaceTest_spec.js
  4. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  7. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
  8. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  9. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
  10. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
  11. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
  12. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
  13. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
  14. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
  15. cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
To know the list of identified flaky tests - Refer here

@github-actions
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label May 10, 2023
@github-actions
Copy link

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this May 27, 2023
@sharat87 sharat87 reopened this May 29, 2023
@sharat87 sharat87 removed the Stale label May 29, 2023
@sharat87
Copy link
Member Author

/ok-to-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5265991987.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22941.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22941&runId=5265991987_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265991987.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_TriggerRow_SelectedRow.js

To know the list of identified flaky tests - Refer here

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265991987.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Listv2_TriggerRow_SelectedRow.js

To know the list of identified flaky tests - Refer here

@sharat87 sharat87 marked this pull request as draft March 19, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant