-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Load OAuth2 configurations dynamically #22941
base: release
Are you sure you want to change the base?
Conversation
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4869567675. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4869567675.
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
This PR has been closed because of inactivity. |
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5265991987. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265991987.
To know the list of identified flaky tests - Refer here |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265991987.
To know the list of identified flaky tests - Refer here |
…ith/server/solutions/EnvManagerTest.java
…ith/server/solutions/EnvManagerImpl.java
This PR will load OAuth2 configurations for Google and GitHub dynamically, instead of having Spring pick them up statically at startup.
Why do we need this?
Note that this only contains backend changes, and the client still requests a restart, although it's not required. I'll change client's behaviour there in a separate PR. This one, doesn't break any API contract.