Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: JS Object displayed in editor even when moved to a different page. #33045

Closed
1 task done
Tracked by #33032
shadabbuchh opened this issue Apr 30, 2024 · 0 comments · Fixed by #33066
Closed
1 task done
Tracked by #33032

[Bug]: JS Object displayed in editor even when moved to a different page. #33045

shadabbuchh opened this issue Apr 30, 2024 · 0 comments · Fixed by #33066
Assignees
@hetunandu @rohan-arthur
Labels
Bug Something isn't working FE Coders Pod Issues related to users writing javascript in appsmith IDE Navigation Issues/feature requests related to IDE navigation, and context switching JS Objects Issues related to JS Objects Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Production QA Pod Issues under the QA Pod QA Needs QA attention UX Improvement

Comments

@shadabbuchh
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

When we move a JS Object to a different page, we are still able to see it in the editor of the page from where it was moved.

Steps To Reproduce

  1. Create an app and add a JS Object to Page1.
  2. Now create a new page Page2.
  3. Move the JS Object from Page1 to Page2.

Expected: The JS Object should not be visible in the editor of Page1 anymore.
Actual: JS Object is still visible.

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

https://www.loom.com/share/6a6c9c9ab02149eea3ae8d514f3eca27

Version

Cloud
@shadabbuchh shadabbuchh added Bug Something isn't working UX Improvement Production Needs Triaging Needs attention from maintainers to triage JS Objects Issues related to JS Objects Medium Issues that frustrate users due to poor UX IDE Navigation Issues/feature requests related to IDE navigation, and context switching labels Apr 30, 2024
@github-actions github-actions bot added New Developers Pod Issues that new developers face while exploring the IDE FE Coders Pod Issues related to users writing javascript in appsmith labels Apr 30, 2024
This was referenced May 1, 2024
Closed
Merged
hetunandu added a commit that referenced this issue May 8, 2024
@hetunandu
fix: The case of the missing tabs (#33066)
0a58544 
## Description

Solves scenarios where open tabs data was lost on page switches

Fixes #33032
Change the data structure of the tabs to now keep account different tabs
for each page instead of just one page at a time. Also removed tabs
state for focus retention.

Fixes #33045
Handles removing and navigating post move of JS and Queries to avoid
being in a bad state


## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9000257489>
> Commit: b39c8d7
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9000257489&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




















## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
@appsmith-bot appsmith-bot added the QA Needs QA attention label May 8, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetunandu hetunandu

@rohan-arthur rohan-arthur

Labels
Bug Something isn't working FE Coders Pod Issues related to users writing javascript in appsmith IDE Navigation Issues/feature requests related to IDE navigation, and context switching JS Objects Issues related to JS Objects Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Production QA Pod Issues under the QA Pod QA Needs QA attention UX Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: The case of the missing tabs appsmithorg/appsmith
4 participants
@hetunandu @shadabbuchh @appsmith-bot @rohan-arthur