Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: IDE Tabs go missing in a few cases #33032

Closed
2 tasks done
hetunandu opened this issue Apr 29, 2024 · 0 comments · Fixed by #33066
Closed
2 tasks done

[Bug]: IDE Tabs go missing in a few cases #33032

hetunandu opened this issue Apr 29, 2024 · 0 comments · Fixed by #33066
Assignees
@hetunandu
Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Issues related to the IDE Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Production QA Pod Issues under the QA Pod QA Needs QA attention

Comments

@hetunandu
Copy link
Member

hetunandu commented Apr 29, 2024 •
edited

Description

Tabs are going missing and not being saved correctly

Steps To Reproduce
@hetunandu hetunandu added Bug Something isn't working IDE Issues related to the IDE Needs Triaging Needs attention from maintainers to triage IDE Navigation Issues/feature requests related to IDE navigation, and context switching labels Apr 29, 2024
@hetunandu hetunandu self-assigned this Apr 29, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Low An issue that is neither critical nor breaks a user flow Production labels Apr 29, 2024
@github-actions github-actions bot added the New Developers Pod Issues that new developers face while exploring the IDE label Apr 29, 2024
@rohan-arthur rohan-arthur mentioned this issue May 1, 2024
Open
1 task
@hetunandu hetunandu mentioned this issue May 2, 2024
Merged
2 tasks
hetunandu added a commit that referenced this issue May 8, 2024
@hetunandu
fix: The case of the missing tabs (#33066)
0a58544 
## Description

Solves scenarios where open tabs data was lost on page switches

Fixes #33032
Change the data structure of the tabs to now keep account different tabs
for each page instead of just one page at a time. Also removed tabs
state for focus retention.

Fixes #33045
Handles removing and navigating post move of JS and Queries to avoid
being in a bad state


## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9000257489>
> Commit: b39c8d7
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9000257489&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




















## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
@appsmith-bot appsmith-bot added the QA Needs QA attention label May 8, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetunandu hetunandu

Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Issues related to the IDE Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Production QA Pod Issues under the QA Pod QA Needs QA attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: The case of the missing tabs appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @hetunandu @appsmith-bot